-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completion: teach commands about files #4887
Conversation
139062f
to
0e55763
Compare
4b076bb
to
c3335a6
Compare
@yuja are you ok with the |
ce5fd3c
to
d82e1dc
Compare
f7c52c4
to
12d96d4
Compare
Suppose it is a temporary workaround for clap-rs/clap#5784, I don't mind if the |
697fd99
to
d295af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM, but please give Yuya a chance to review since he's already reviewed an earlier version of it.
This is heavily based on Benjamin Tan's fish completions: https://gist.github.com/bnjmnt4n/9f47082b8b6e6ed2b2a805a1516090c8 Some differences include: - The end of a `--from`, `--to` ranges is also considered. - `jj log` is not completed (yet). It has a different `--revisions` argument that requires some special handling.
d295af2
to
18628c1
Compare
This is heavily based on Benjamin Tan's fish completions:
https://gist.github.com/bnjmnt4n/9f47082b8b6e6ed2b2a805a1516090c8
Some differences include:
--from
,--to
range is also considered.jj log
is not completed (yet). It has a different--revisions
argumentthat requires some special handling.
Checklist
If applicable:
CHANGELOG.md