Fix HTTPGzipProcessor #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Discard gzip header after content has been decompressed
2. Return addinfourl object so that HTTPEquivProcessor can use
the result of HTTPGzipProcessor
|
Thank you for your contribution to mechanize! Following the process in #117, future work on mechanize will be occurring here: Please re-file your PR there (where it will get attention, and hopefully merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we've been using mechanize and noticed that if a page was gzipped, mechanize just chokes by spitting out a stacktrace. I found the HTTPGzipProcessor, but it appeared to be bit-rotted and did not work correctly with HTTPEquivProcessor, so I fixed it up to correctly subclass addinfourl, and also discard the content-encoding:gzip header after the content has been decompressed (or else clients try to decompress something that is already decompressed).
The version I'm sending a pull request for works for gzip and non-gzip pages, if you include the HTTPGzipProcessor in your OpenerDirector (in our shop we have our own custom OD).
Let me know if you have any concerns about the changes, or suggestions for how to do it better. I'll be writing up a blog post about this in the next few days at http://jasonkotenko.com.
Thanks,
Jason Kotenko