Issue 144: Option to copy instead of move file#150
Open
WaywardWizard wants to merge 10 commits intojkwill87:mainfrom
Open
Issue 144: Option to copy instead of move file#150WaywardWizard wants to merge 10 commits intojkwill87:mainfrom
WaywardWizard wants to merge 10 commits intojkwill87:mainfrom
Conversation
WaywardWizard
commented
Jun 15, 2021
| help="--episode-format: set episode renaming format specification", | ||
| )(), | ||
| ) | ||
| relocation_mode: Optional[Union[RelocateType,str]] = dataclasses.field( |
Author
There was a problem hiding this comment.
Not sure why we must allow items of type "RelocateType". But i see that was done elsewhere. I think this is redundant because we only pass instances of str and never of RelocateType.
WaywardWizard
commented
Jun 16, 2021
added 6 commits
June 16, 2021 16:29
|
Nice work thanks, hope it gets merged soon. a hardlink option would be nice as well. |
Author
Thanks @bakman2 Ive forgotten now but im 99pct sure that link() - hardlink and symlink() - symbolic link |
jkwill87
force-pushed
the
main
branch
3 times, most recently
from
f426ba5 to
0a13fd7
Compare
Author
|
@jkwill87 If i resolved these conflicts, would you be willing to merge? Would there be anything further you would like to see? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue/request #144