fixed filename iso-code overwriting explicit --language flag#334
Open
enodden wants to merge 1 commit intojkwill87:mainfrom
Open
fixed filename iso-code overwriting explicit --language flag#334enodden wants to merge 1 commit intojkwill87:mainfrom
enodden wants to merge 1 commit intojkwill87:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detailed in issue #330, the explicit --language flag is overwritten if GuessIt detects an ISO code in the filename.
The fix in this PR is just adding a check after GuessIt parsing to see if the --language flag is set. If it was, then it restores the user-configured language in path_data. This should ensure that the --language flag is always respected, while still allowing GuessIt to populate other fields in path_data.