The success flag, once set to false, is never reset to true#3
Open
jamestyrrell wants to merge 1 commit intojline:masterfrom
Open
The success flag, once set to false, is never reset to true#3jamestyrrell wants to merge 1 commit intojline:masterfrom
jamestyrrell wants to merge 1 commit intojline:masterfrom
Conversation
…a beep to occur on each subsequent key press. This commit just moves the success variable declaration to its previous location so it is re-declared on each read loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
I am on the Roo team and I ran into a bug in the 1.0.0 release. Basically the success flag, once set to false, is never reset to true causing a beep to occur on each subsequent key press. This commit just moves the success variable declaration to its previous location so it is re-declared on each read loop.
Cheers,
Jim