Improve filename completion#204
Open
tkruse wants to merge 6 commits intojline:masterfrom
tkruse:improve-filename
Open
Improve filename completion#204tkruse wants to merge 6 commits intojline:masterfrom tkruse:improve-filename
tkruse wants to merge 6 commits intojline:masterfrom
tkruse:improve-filename
Conversation
- duplicate code into shared method - removed useless isQuote() Method. Logic for quote is in main loop.
…open quotes This breaks the API by extending the interface ArgumentCompleter.ArgumentDelimiter Not sure whether this is still acceptable for jline2 2.x
- provide option to complete folders themselves - provide option to not complete files - allow suppressing final blank (fix #90)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supercedes #203.
This fixes #90, and adds a lot of tests and some features to FileNameCompleter and ArgumentCompleter.
ArgumentCompleter will now attempt escape candidates based on the ArgumentDelimiter. This should help e.g. with Filenames having blanks. If the argument is within the context of an opening quote, no escaping will happen, but the argumentHandler will provide a closing quote if the subcompleter suggests a candidate ending with a delimiter (blank).
FileNameCompleter can now configured to not provide a blank, it can be configured to complete folders themselves and also to not complete files (just folders if that is enabled), and users can add a filter in subclasses to exclude files based on custom logic.
I did not test the changes on other operating systems than Linux.
The small commits fixing minor stuff could be merged early, if you like.