Skip to content

[FIX] Fix register_existing_resources #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FIX] Fix register_existing_resources #236

wants to merge 2 commits into from

Conversation

paaanic
Copy link

@paaanic paaanic commented Jul 13, 2022 •
edited
Loading

This PR contains 2 changes in FlaskApiSpec.register_existing_resources:

  • Move skipping static rules to the beginning as there is no need to try splitting names if we want to continue loop
  • Change name.split -> name.rsplit(..., maxsplit=1) to handle nested blueprints because they produce more than one dot in name

paaanic added 2 commits July 13, 2022 21:55
@paaanic
Fix register_existing_resources
5e85aca 
Move skipping static rules to the beginning of the loop
@paaanic
Fix register_existing_resources
3c95b5d 
Add handling of nested blueprints in name splitting
@paaanic paaanic changed the title Fix routes autodiscovering [FIX] Fix register_existing_resources Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paaanic