Drop ExteriorRadius overrides; inherit from Location component#45
Open
jneb802 wants to merge 1 commit into
Open
Drop ExteriorRadius overrides; inherit from Location component#45jneb802 wants to merge 1 commit into
jneb802 wants to merge 1 commit into
Conversation
…tion component Removes all explicit ExteriorRadius assignments from LocationDefinitions (129 entries across every biome). With the Jötunn nullable-config fix in place, leaving ExteriorRadius unset lets CustomLocation.SyncZoneLocationFromComponent copy the Unity-Editor-authored value from the prefab's Location component onto ZoneLocation, eliminating the mismatch that caused LocationReset and ClearArea to operate on a smaller radius than the visible footprint. Updates bundled Jotunn.dll to the build carrying the nullable LocationConfig fields (fix/location-exterior-radius-from-prefab). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExteriorRadiusassignments fromLocationDefinitions.cs. With the paired Jötunn fix (jneb802/Jotunn#fix/location-exterior-radius-from-prefab),CustomLocation.SyncZoneLocationFromComponentnow copies the Unity-Editor-authored radius from the prefab'sLocationcomponent ontoZoneLocationwhen the config field is left unset.ZoneLocation.m_exteriorRadius(used by world-gen,ClearArea, slope sampling, and consumers like VentureValheim/LocationReset) andLocation.m_exteriorRadius(authored in Unity, visible in-scene).Libs/Jotunn.dllto a build carrying the nullableLocationConfigfields required for this to compile and run.Why
LocationReset.LocationPositionreadszone.m_exteriorRadiusoffZoneSystem.ZoneLocation, not the prefab'sLocationcomponent. Before this change, that value was the (often smaller)LocationConfig.ExteriorRadiusvalue — so reset operated on a subset of the location's actual footprint and left objects beyond the config radius unreset. The Unity-Editor-authored radius is the only place the footprint is actually visible, so making it the source of truth prevents the two from drifting.Test plan
dotnet buildclean against the paired Jötunn branch.developprofile.MWL_GoblinFort1picks up its prefab-authored radius through the SoftReference sync path.