Test on all Java LTS

[juherr]

Summary:

• Added CI tests for all Java LTS versions (starting from 8).
• Integrated examples into the CI workflow to improve test coverage. Rework ci pipeline #1735
• Fixed various issues to ensure all tests pass successfully.

[juherr]

@joelittlejohn The build is now working on all Java LTS versions, except for some details:

• Robolectric tests are disabled on Java11 and later due to NoClassDefFoundError: androidx/test/platform/app/InstrumentationRegistry when upgrade from 3.8 to 4.13 robolectric/robolectric#9492
• Android sample ci is disabled on Java8 because of an incompatibility issue between gradle and the very old android pluging

[juherr]

Ping @joelittlejohn

[ctrimble]

@juherr I would like to try and get this PR moving again.

I have the robolectric issues resolved up to Java 17 in #1704. I am going to pull that into master soon.

Once I have #1704 on master, would you want to pick this back up, rebase to get it current, and try to get something onto master?

[juherr]

@ctrimble Sure. Let me know when the main branch is ready.

[ctrimble]

@juherr the master branch now has JDK 11 and JDK 17 support for the integration tests.

I am still not sure how @joelittlejohn is doing releases for this project. Hopefully he can take a peek and verify that we are not going to break release procedures with this update.

[ctrimble]

I have added #1722 to get the maven wrapper into the project. This commit cherry-picked over without any changes needed.

[ctrimble]

#1722 is now on master. @juherr is there anything else in here that is not specifically about adding JDK 11,17,21 support?

[ctrimble]

@juherr I have push a rebased branch to my fork. Please force push https://github.com/ctrimble/jsonschema2pojo/tree/feature_test-all-lts onto your branch when you get a chance.

It looks like we could also move the following changes to other PRs as improvements:

• Upgrading Gradle/gradlew in the gradle module.
• Making examples more consistent.
  • Moving the maven example to be more consistent with other examples.
  • The dependabot updates for examples
  • Naming cleanup in the maven example

This would leave us with just the changes that are about this feature. That should make this PR much easier to review and get committed. I am going to see if I can get those broken out and onto master.

[ctrimble]

#1723 was added with the gradle update. The rebased branch in my repo was also updated.

I am going to gather up these example updates into a PR next.

[juherr]

Please check #1714 first. It should help to review too.

[juherr]

@juherr I have push a rebased branch to my fork. Please force push https://github.com/ctrimble/jsonschema2pojo/tree/feature_test-all-lts onto your branch when you get a chance.

Ok, I will do that.

[ctrimble]

Please check #1714 first. It should help to review too.

Thanks for the heads up on that PR. I thought we needed to merge that after this PR. I now understand.

I am hoping to get all of this merged in smaller chunks. It is good work, but it is too much to do in one shot.

[juherr]

@ctrimble Done. JDK 25 should be added now.
By the way, I can’t remember why the Maven example is still limited to JDK 8. Maybe worth trying again?

[ctrimble]

@juherr the example updates are now on master. I have updated https://github.com/ctrimble/jsonschema2pojo/tree/feature_test-all-lts again. Please force push those changes to your branch and we should be ready to review this change in isolation.

[ctrimble]

@juherr Dude, the enthusiasm is great, but please stop adding things. Take a minute to update the description box at the top of this PR, clearly define what this PR now accomplishes and stick to just that.

Note: It is fine if we want to include JDK 25 now, since we really have this narrowed down to just version support, but the change in scope is killing me.

[juherr]

@ctrimble The goal of this pr has always been the same: to ensure the project runs correctly on all LTS versions.
Unfortunately, a new LTS was released just a month ago 😅

[juherr]

@ctrimble As you did over the last few days (thanks again for that!), an additional PR could introduce all the examples as a CI step.
The final step would then be to run tests across all LTS versions.

[ctrimble]

@juherr

Take a minute to update the description box at the top of this PR, clearly define what this PR now accomplishes and stick to just that.

[juherr]

@juherr

Take a minute to update the description box at the top of this PR, clearly define what this PR now accomplishes and stick to just that.

Done

[juherr]

@ctrimble As you did over the last few days (thanks again for that!), an additional PR could introduce all the examples as a CI step. The final step would then be to run tests across all LTS versions.

Done here: #1735