Skip to content

Conversation

@gr0l
Copy link

@gr0l gr0l commented May 17, 2024

When using remote URL's like an HTTP-Url as sourcePaths input. The URL's have been normalized to a file like notation. Afterwards the type generator was unable to resolve the remote file.

@ctrimble ctrimble self-requested a review September 3, 2025 20:23
@ctrimble
Copy link
Collaborator

ctrimble commented Sep 3, 2025

@gr0l I know this PR has been open for some time, but I am actively trying to get a 1.2.3 release put together. This seems like a bug. I will give it a review and see if we can get it merged.

@ctrimble ctrimble added this to the 1.2.3 milestone Sep 3, 2025
@ctrimble
Copy link
Collaborator

@gr0l Hello! Is there any chance you can get this on top of master and squash it into a single commit?

@gr0l
Copy link
Author

gr0l commented Oct 17, 2025

@ctrimble I merged the current master into my fork. Does github not support squashing, when the merge is applied?

@ctrimble
Copy link
Collaborator

ctrimble commented Oct 17, 2025

@gr0l I am running off of the existing convention, which is to bring in PRs with a merge commit. I was hoping you could just git rebase -i master this, drop all of the merge commits and squash your second real commit onto the first, then force push your branch. The way this is, there will be all kinds of strange merge commits in the history. Not the end of the world, but it does make sorting through history difficult.

Changing to EnumSet instead of Streaming API
@gr0l
Copy link
Author

gr0l commented Oct 17, 2025

@ctrimble Done

@ctrimble
Copy link
Collaborator

@gr0l Thanks for the contribution. I am going to work up an integration test for this. Once I finish that, this will get merged.

@ctrimble ctrimble merged commit 6a8aff3 into joelittlejohn:master Oct 17, 2025
3 checks passed
@ctrimble
Copy link
Collaborator

@gr0l I got a test put together for this. It fails without your code and passes with it, so everything looks in order.

Thanks again for your PR and your willingness to restructure history. I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants