fix: renaming the role back to internal-services-manager-rolebinding

This commit renames the ClusterRole and the RoleBinding adding the prefix _internal-services_ to them. Also adds the user mmalina to the users list. Signed-off-by: Leandro Mendes <[email protected]>
johnbieren · Jun 7, 2024 · 0fa9d65 · 0fa9d65
1 parent c52ede5
commit 0fa9d65
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/app_interface.yaml b/.github/workflows/app_interface.yaml
@@ -12,7 +12,7 @@ jobs:
       NAMESPACE: stonesoup-int-srvc
       REMOTE_CLIENT_CONFIG_SECRET: remote-client-config
       REMOTE_CLIENT_CONFIG_MOUNT_PATH: "/mnt/internal-services/remote-client-config"
-      USERS: "damoreno jbieren lmendes shebert"
+      USERS: "damoreno jbieren lmendes shebert mmalina"
       YQ_VERSION: "v4.30.8"
     steps:
       - name: Checkout internal-services repo

diff --git a/Makefile b/Makefile
@@ -93,7 +93,7 @@ help: ## Display this help.
 
 .PHONY: manifests
 manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
-	$(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
+	$(CONTROLLER_GEN) rbac:roleName=internal-services-manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
 
 .PHONY: generate
 generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -3,7 +3,7 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   creationTimestamp: null
-  name: manager-role
+  name: internal-services-manager-role
 rules:
 - apiGroups:
   - appstudio.redhat.com

diff --git a/config/rbac/role_binding.yaml b/config/rbac/role_binding.yaml
@@ -3,7 +3,7 @@ kind: ClusterRoleBinding
 metadata:
   labels:
     app.kubernetes.io/name: clusterrolebinding
-    app.kubernetes.io/instance: manager-rolebinding
+    app.kubernetes.io/instance: internal-services-manager-rolebinding
     app.kubernetes.io/component: rbac
     app.kubernetes.io/created-by: internal-services
     app.kubernetes.io/part-of: internal-services
@@ -12,7 +12,7 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: manager-role
+  name: internal-services-manager-role
 subjects:
 - kind: ServiceAccount
   name: controller-manager