ci: dispatch CI onto release-please PRs so required checks report - #54
Merged
Conversation
GitHub now gates pull_request workflow runs from bot-authored PRs behind manual approval, so CI never starts on the release-please PR and its required checks (test/npm/deny, pinned to the Actions app) sit at Expected forever, blocking the release PR. Dispatch ci.yml onto the release branch from the release workflow instead: a workflow_dispatch run carrying GITHUB_TOKEN is exempt from the approval gate and produces real Actions check runs. The jobs' release-please skip guard now also matches ref_name, so the dispatched run reports the checks green in seconds without re-running the suite.
johncarmack1984
added a commit
that referenced
this pull request
Aug 10, 2026
Dispatching CI onto the release-please branch (#54) never reported the required checks: prs_created is false on changelog-neutral pushes so the dispatch step skipped, and even unguarded it would fail because the release branch is only rebuilt when the changelog changes, so its stale ci.yml lacks the workflow_dispatch trigger. Instead, the release workflow now creates the test/npm/deny check runs directly via the Checks API with GITHUB_TOKEN. Only GitHub Apps can create check runs, and GITHUB_TOKEN is the Actions app's token, so the stamps satisfy the ruleset's app-pinned contexts; a 'skipped' conclusion counts as passing. This has zero dependence on release-please outputs, the branch's file contents, or workflow triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR #53 is stuck: GitHub now gates
pull_requestworkflow runs from bot-authored PRs behind manual approval, so CI never starts on the release-please branch and the required checks (test/npm/deny, pinned to the GitHub Actions app in the main ruleset) sit at Expected — Waiting for status to be reported forever. The #50 self-skip guard assumed the workflow would still trigger; it no longer does.Fix, with no GitHub App or PAT:
release.yml: after release-please creates or updates the release PR, dispatchci.ymlonto the release branch viagh workflow run(newactions: writepermission). API-dispatched runs carryingGITHUB_TOKENare exempt from the bot-PR approval gate and produce real Actions check runs at the PR head SHA — which is what the app-pinned ruleset requires.ci.yml: add theworkflow_dispatchtrigger and extend the three jobs' release-please skip guard to also matchref_name(the dispatched run has an emptyhead_ref), so the dispatched run's jobs skip instantly and report the checks green with zero redundant compute. Normal PRs and the main-pushworkflow_callstill run the full suite.On merge, release-please rebuilds #53's branch from main (picking up the dispatch trigger), the new step fires, and #53 goes green with no manual approval.