fix(auth): pairing follow-ups — grant identity fields and a visible deletion blast radius - #212
Merged
Merged
Conversation
The grant reported the Cognito username as `email` — a UUID for Apple-created accounts, which the node would then store and log as the account identity. Return the email attribute (username fallback), plus the app client id that minted the refresh token so the node never has to guess which client to refresh against. Adds GET /auth/device/list — the account's paired-device registry, needed by the app's device list and the delete-account confirm.
Deleting an account is very effective — today it took the founder's with it. The confirm now names what goes: the signed-in email, the cloud-synced setup count, and any paired lux-node devices (via the new /auth/device/list), so 'test the deletion flow' and 'delete my real account' stop looking identical at the moment of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two 1.7.1 fixes out of tonight's account-deletion incident and first real device pairing:
/auth/device/tokennow returns the account's email attribute (was: Cognito username, a UUID for Apple-created accounts) and the minting client id, so paired nodes write a complete, correct session without guessing (pairs with feat(node): sessions record the app client that minted them #210).