Add two explicit type arguments to make it compatible with SIP-56.#101
Open
sjrd wants to merge 1 commit intojohnhungerford:masterfrom
Open
Add two explicit type arguments to make it compatible with SIP-56.#101sjrd wants to merge 1 commit intojohnhungerford:masterfrom
sjrd wants to merge 1 commit intojohnhungerford:masterfrom
Conversation
The new match types of SIP-56 feature a stricter check to prevent some run-time unsoundness. This affects the line that is changed here. For example, for the second `.head` call, the type argument was previously inferred to `RV & (F *: vts)`. The previous check that was too relaxed let it through, although `RV` is not fully defined. We still obtain valid code by passing the new explicit type arguments instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new match types of SIP-56 feature a stricter check to prevent some run-time unsoundness. This affects the line that is changed here. For example, for the second
.headcall, the type argument was previously inferred toRV & (F *: vts). The previous check that was too relaxed let it through, althoughRVis not fully defined. We still obtain valid code by passing the new explicit type arguments instead.