Part two answer #13
Open
Part two answer #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CSS styling, more reading needed.
johnny-rice
reviewed
Jun 17, 2020
|
|
||
| <style> | ||
| body { |
johnny-rice
reviewed
Jun 17, 2020
| subtractNumbers: function () { | ||
|
|
||
| let numberOne = parseInt(document.forms.inputs.numberOne.value); |
johnny-rice
reviewed
Jun 17, 2020
index.html
Outdated
| </script> | ||
|
|
||
| </head> | ||
|
|
||
| <body> | ||
| <div>Header</div> | ||
| <H1>Calculator 1.2</H1> |
johnny-rice
reviewed
Jun 17, 2020
index.html
Outdated
| </div> | ||
| <div> | ||
| <button type="button" class="btn btn-primary" onclick="calculator.addNumbers()" >Add</button> | ||
| <button type="button" class="btn btn-primary">Substract</button> | ||
| <button type="button" class="btn btn-primary" padding: 50px 25px |
There was a problem hiding this comment.
This all looks good. There is an issue though. The "padding" and related values all has to e removed. You can add that to the btn, btn-primary or other css class if you want to include padding. It is not valid to put a direct padding attribute on any html tag.
johnny-rice
requested changes
Jun 17, 2020
|
Got it! Thanks for looking over all this, I'll fix the add logic/concat.
issues and incorrect inline button padding in the morning! I've been
digging into more css guides today, will be pushing up a few new things
too. -Nick.
…On Tue, Jun 16, 2020, 22:34 John Rice ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please review the add logic related to strings and concatenation. Also
please try to resolve the use of the padding: 50px 25px that is in the
tags. This code belongs in the style tag associated to a class name
selector.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGFHTII2QJU4PN4VNPG3Y5DRXATTPANCNFSM4N4VZN7A>
.
|
…unctions work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic introduction of other operators and changing var usage to let. Want to edit the number entering form to be able to take any given numbers and introduce button for 'equals' operation in the near future.