allow patches to be falsy values

joist-framework · Jan 25, 2025 · de65a2e · de65a2e
1 parent b648a6b
commit de65a2e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/integration/counter/src/counter.ts b/integration/counter/src/counter.ts
@@ -53,7 +53,6 @@ export class CounterElement extends HTMLElement {
   }
 
   #update(change: number) {
-    const value = Number(this.innerHTML.trim());
-    this.innerHTML = String(value + change);
+    this.innerHTML = String(Number(this.innerHTML.trim()) + change);
   }
 }
diff --git a/packages/element/src/lib/query-all.ts b/packages/element/src/lib/query-all.ts
@@ -63,8 +63,8 @@ function patchNodes<T extends HTMLElement>(
         const newValue = patch[update];
         const oldValue = node[update];
 
-        if (newValue && newValue !== oldValue) {
-          node[update] = newValue;
+        if (newValue !== oldValue) {
+          Reflect.set(node, update, newValue);
         }
       }
     }

diff --git a/packages/element/src/lib/query.ts b/packages/element/src/lib/query.ts
@@ -56,8 +56,8 @@ function patchNode<T extends HTMLElement>(
     const newValue = patch[key];
     const oldValue = target[key];
 
-    if (newValue && newValue !== oldValue) {
-      target[key] = newValue;
+    if (newValue !== oldValue) {
+      Reflect.set(target, key, newValue);
     }
   }