Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for performance considerations when reading composite components #130

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

jship
Copy link
Collaborator

@jship jship commented Feb 5, 2024

Closes #127. I'll attach a screenshot of the rendered Haddocks in case that's easier to review:

image

Copy link
Owner

@jonascarpay jonascarpay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was a little verbose, so here are some suggestions. Other than that this looks good, thanks for picking this up.

@jonascarpay
Copy link
Owner

jonascarpay commented Mar 6, 2024

Shit I pressed the update branch from my phone thinking it would rebase instead of merging. I'll clean this up later and merge into master

@jonascarpay jonascarpay merged commit c7707ea into jonascarpay:master Mar 6, 2024
19 checks passed
@jship jship deleted the perf-docs branch March 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of components in explMembers matters
2 participants