Clear google-chrome's LD_LIBRARY_PATH before spawning the player #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Chrome ships with bundled libvulkan.so.1 and links to it by setting LD_LIBRARY_PATH in the startup script. When acestream-launcher is invoked from chrome through the acestream:// protocol, the environment variables are passed in and eventually passed to the player. In fedora + rpmfusion, when mpv is spawned it fails to link because it attempts to link against google's build of libvulkan instead of the system provided library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Chrome ships with bundled libvulkan.so.1 and links to it by
setting LD_LIBRARY_PATH in the startup script.
When acestream-launcher is invoked from chrome through the
acestream:// protocol, the environment variables are passed in
and eventually passed to the player.
In fedora + rpmfusion, when mpv is spawned it fails to link because
it attempts to link against google's build of libvulkan instead of
the system provided library.
This is hacky but i think it's fine to fix the issue in acestream-launcher even though it's not its fault, since it's the bridge between the browser and mpv