Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Improvements Quicky #314

Merged
merged 12 commits into from
Feb 16, 2025
Merged

GCP Improvements Quicky #314

merged 12 commits into from
Feb 16, 2025

Conversation

jonrau1
Copy link
Owner

@jonrau1 jonrau1 commented Feb 16, 2025

GCP was the second CSP I added support for, then quickly forgot about it because I suck at writing Python and GCP docs aren't great. Well now I'm many years wiser, and I still suck at Python, but I can read a bit better. Which is good because GPT o3-mini and whatever the hell GitHub CoPilot use absolutely make shit up when it comes to the lower-level googleapiclient.discovery.

Anyway...

  • Fixed the GCP Assessment Target! I broke it when I did the TOML refactor a year or so ago, shows me that no one uses it lol. Fixed a bug where I had the wrong argument
  • Uses a GCP Credentials object to pass to the various clients instead of writing to a file and passing the path to file as an ENV VAR. One day I need to swap to WIF support.
  • Added 2 new auditors, a 2-check BigQuery auditor (that's all you can really do) and an IAM Auditor I will come back to (next year lol)
  • Updated the docs to annotate how to properly escape an IAM SA JSON Key, if you choose to paste it into the TOML
  • Updated iconography, control statements, and the big check tracker readmes
  • Bumped to Alpine 3.21.3 as of 2 days ago (13 FEB 2025)

@jonrau1 jonrau1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file docker Pull requests that update Docker code python Pull requests that update Python code gcp For Google Cloud Platform. NOT WORKSPACE labels Feb 16, 2025
@jonrau1 jonrau1 self-assigned this Feb 16, 2025
@jonrau1 jonrau1 mentioned this pull request Feb 16, 2025
@jonrau1 jonrau1 merged commit d4de53e into master Feb 16, 2025
4 checks passed
@jonrau1 jonrau1 deleted the gcp_improvements_2025 branch February 16, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file docker Pull requests that update Docker code documentation Improvements or additions to documentation enhancement New feature or request gcp For Google Cloud Platform. NOT WORKSPACE python Pull requests that update Python code
Projects
Development

Successfully merging this pull request may close these issues.

1 participant