Skip to content
This repository was archived by the owner on Aug 15, 2021. It is now read-only.

Conversation

elkami12
Copy link

@elkami12 elkami12 commented Aug 24, 2016

First thanks for your work !

This pull request is for:

Feedback icons only work with textual elements.

  • add a new feature for inserting help-block in specific place. Sometime it can be useful to be able to set precisely where the help-block should be added if element becomes invalid.
    Now you can just put a container with help-block-cont class inside the form-group to force the help-block to be added in it.
    It is particularly useful with horizontal forms with grid structure.
    Example:
<div class="form-group">
    <label for="xxx" class="col-sm-5 control-label">Label_XXX</label>
    <div class="col-xs-6 col-sm-2">
        <input id="xxx" name="xxx" ng-model="vm.xxx" type="number" class="form-control" required>
    </div>
    <div class="col-xs-6 col-sm-5">
        <p class="form-control-static">more text</p>
    </div>
    <div class="clearfix"></div>
    <div class="col-xs-12 col-sm-7 col-sm-offset-5 help-block-cont"></div>
</div>

Cordially and sorry for my english...

… validationStateIcon (if enabled).

This avoid wired display for this kind of input since according to bootstrap documentation: "Feedback icons only work with textual <input class="form-control"> elements." (http://getbootstrap.com/css/#forms-control-validation)
@elkami12 elkami12 changed the title Add support for bootstrap checkbox and radio buttons Correct icons for select, check and radio + Add support for bootstrap checkbox and radio buttons Aug 24, 2016
Sometime it can be useful to be able to set precisely where the help-block should be added if element becomes invalid
Now you can just put a "help-block-cont" element inside the form-group to force the help-block to this container.
@elkami12 elkami12 changed the title Correct icons for select, check and radio + Add support for bootstrap checkbox and radio buttons Correct icons for select, check and radio + Add support for bootstrap checkbox and radio buttons + add support for specific help-block container Aug 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant