Update is-descriptor to fix vulnerability #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update is-descriptor to 3.0.0 - Update mocha to 7.1.0 - Add "enumerable" and "configurable" to test cases to ensure it complies with new is-descriptor check.
|
Looks like all Travis builds on Seems like the current oldest supported version is 8 (in maintenance LTS)? |
I would drop the older versions of node if that's possible. What do you think @jonschlinkert ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version ^1.0.2 of
is-descriptorcurrently being used depends on a library with a vulnerability as described here.This PR updates the dependency to its latest version which no longer depends on the aforementioned library, and updates the test code to adhere to the latest specification which requires both
configurableandenumerableto be defined to be recognized as a valid descriptor.While at it, I also updated
mochato the latest version to resolvenpm auditvulnerabilities.