-
-
Notifications
You must be signed in to change notification settings - Fork 4
AI Framework Foundation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /** | ||
| * Part of the Joomla Framework AI Package | ||
| * | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the headers Joomla is using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed them with commit#4. Please check. I am not sure what should be the copyright for 2025, could you please confirm and I will update it in my next commit
src/AbstractProvider.php
Outdated
| */ | ||
| protected function validateResponse($response): bool | ||
| { | ||
| if ($response->code !== 200) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is only a 200 a valid response?
|
With the latest commit, the following changes have been made:
|
| "require": { | ||
| "php": "^8.1.0", | ||
| "joomla/http": "dev-4.x-dev", | ||
| "joomla/filesystem": "~3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use version 4.x now for both (they're released)
Pull Request for AI Framework Feature.
Summary of Changes
Response.phpis the foundational file for the AI framework that standardizes how responses are handled across all AI providers.09 June 2025
ProviderInterface.php: All AI providers must implement these methods.AbstractProvider.php: All providers share this code. It contains shared functionalities for all providers.11 June 2025
Testsfolder contains basic php tests.Testing Instructions
Documentation Changes Required