[5.3] Improve api app code using rector rules

[joomdonation]

Pull Request for Issue # .

Summary of Changes

The api does not contain much code, so I run several rector rules at once (same as the rules I use for components and libraries code) to improve code of our api application. All the changes here are done by rector, no manual change needed.

Turned out, only 3 rules applied:

• ListToArrayDestructRector
• StrContainsRector
• RemoveUnusedVariableInCatchRector

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[QuyTon]

I have tested this item ✅ successfully on 96c756e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.}

[alikon]

#44976 cross reference

[joomdonation]

#44976 cross reference

@alikon Could you please explain more details? I do not understand your last comment. Thanks !

[alikon]

sorry for the noise
i've added a reference for myself

[alikon]

I have tested this item ✅ successfully on 96c756e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44975.}

[joomdonation]

sorry for the noise i've added a reference for myself

Ah, OK. Thanks

[HLeithner]

thanks