Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Change isset($var) && multiple times to one isset call #44982

Merged

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR improves code quality of our code base by running PHPCS Fixer for combine_consecutive_issets rule.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 23, 2025

I have tested this item ✅ successfully on be06c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on be06c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

@QuyTon
Copy link
Contributor

QuyTon commented Feb 24, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44982.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2025
@HLeithner HLeithner merged commit 40daa53 into joomla:5.3-dev Feb 26, 2025
0 of 2 checks passed
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2025
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants