Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.4] com_contact : Send Copy to Submitter does not work anymore #44988

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

conseilgouz
Copy link
Contributor

Pull Request for Issue #44987 .

Summary of Changes

Delete default="0" for ontact_email_copy checkbox.
This is related to #37174

Testing Instructions

Joomla 5.2.4
In administrator, enable Send Copy to Submitter parameter in Contacts component parameters (tab form).
"Send a copy to yourself" checkbox appears in your contact form.

Fill up all required field in your contact form and check "Send a copy to yourself" checkbox.

Actual result BEFORE applying this Pull Request

Email is sent to the contact but the user doesn't receive anything.

Expected result AFTER applying this Pull Request

Email is sent to the contact and a copy of this email is sent to the user.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@conseilgouz conseilgouz changed the title com_contact : Send Copy to Submitter does not work anymoreUpdate contact.xml [5.2.4] com_contact : Send Copy to Submitter does not work anymoreUpdate contact.xml Feb 23, 2025
@conseilgouz conseilgouz changed the title [5.2.4] com_contact : Send Copy to Submitter does not work anymoreUpdate contact.xml [5.2.4] com_contact : Send Copy to Submitter does not work anymore Feb 23, 2025
@brianteeman
Copy link
Contributor

there are a LOT of inastances of default="0" - I hope nothing else is impacted!!

@joomdonation
Copy link
Contributor

there are a LOT of inastances of default="0" - I hope nothing else is impacted!!

Only checkbox field type is affected. I did a quick search and only found one which is fixed on this PR. Do you see any other checkbox fields which has default="0" ?

@conseilgouz
Copy link
Contributor Author

there are a LOT of inastances of default="0" - I hope nothing else is impacted!!

Only checkbox field type is affected. I did a quick search and only found one which is fixed on this PR. Do you see any other checkbox fields which has default="0" ?

That's the only one I found that contains default="0".

@exlemor
Copy link

exlemor commented Feb 25, 2025

I have tested this item ✅ successfully on 86eeaab

I have tested this successfully - Thanks Pascal.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44988.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 86eeaab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44988.

@joomdonation
Copy link
Contributor

RTC, thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44988.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 25, 2025
@rdeutz rdeutz merged commit 150f520 into joomla:5.2-dev Feb 26, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2025
@QuyTon QuyTon added this to the Joomla! 5.2.5 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants