Fix: Banner clients accept duplicates

administrator/components/com_banners/src/Model/ClientModel.php

@@ -14,6 +14,7 @@
 use Joomla\CMS\MVC\Model\AdminModel;
 use Joomla\CMS\Table\Table;
 use Joomla\CMS\Versioning\VersionableModelTrait;
+use Joomla\CMS\Language\Text;
 
 // phpcs:disable PSR1.Files.SideEffects
 \defined('_JEXEC') or die;
@@ -135,4 +136,58 @@ protected function prepareTable($table)
     {
         $table->name = htmlspecialchars_decode($table->name, ENT_QUOTES);
     }
+
+        /**
+     * Override save to prevent duplicate client names when saving as copy.
+     *
+     * @param   array  $data  The form data.
+     *
+     * @return  boolean  True on success, false on failure.
+     *
+     * @since   5.3.5
+     */
+    public function save($data)
+    {
+        $table = $this->getTable();
+
+        // If saving as copy or duplicate exists, generate a unique name
+        if (isset($data['name'])) {
+            $table->load(['name' => $data['name']]);
+
+            // Only modify name if it's a duplicate
+            if ($table->id) {
+                $data['name'] = $this->generateUniqueName($data['name']);
+            }
+        }
+
+        return parent::save($data);
+    }
+
+
+
+    /**
+ * Generate a unique client name if it already exists.
+ *
+ * @param string $name The original client name
+ *
+ * @return string Unique client name
+ */
+    protected function generateUniqueName($name)
+    {
+        $table = $this->getTable();
+        $baseName = $name;
+        $i = 2;
+
+        // Keep appending numbers until the name is unique
+        while ($table->load(['name' => $name])) {
+            $name = $baseName . ' (' . $i . ')';
+            $i++;
+        }
+
+        return $name;
+    }
+
+
+
+
 }

administrator/language/en-GB/com_banners.ini

@@ -202,5 +202,7 @@ COM_BANNERS_TYPE2="Clicks"
 COM_BANNERS_UNLIMITED="Unlimited"
 COM_BANNERS_WARNING_PROVIDE_VALID_NAME="Please provide a valid, non-blank name"
 COM_BANNERS_XML_DESCRIPTION="This component manages banners and banner clients."
+COM_BANNERS_CLIENT_ERROR_DUPLICATE_NAME="A client with this name already exists."
+
 
 JLIB_RULES_SETTING_NOTES_COM_BANNERS="Changes apply to this component only.<br><em><strong>Inherited</strong></em> - a Global Configuration setting or higher level setting is applied.<br><em><strong>Denied</strong></em> always wins - whatever is set at the Global or higher level and applies to all child elements.<br><em><strong>Allowed</strong></em> will enable the action for this component unless overruled by a Global Configuration setting." ; Alternate language strings for the rules form field