Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Adds an HTML 5 color picker form field type #358

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

purplebeanie
Copy link
Contributor

This PR adds an HTML 5 color picker form field.

This includes the necessary changes as per the spec here:

http://www.w3.org/TR/html5/forms.html#color-state-(type=color)

Includes unit test.

Add this to a form using:

Cheers,
Eric.

PS: Not sure if I have done this PR correctly.... still trying to get used to using Github for this sort of stuff.

@photodude
Copy link

@purplebeanie Since this PR didn't get merged, Can you send this to the https://github.com/joomla-framework/form repo? This repo is no longer accepting PRs.

@ericfernance
Copy link

Hey @photodude yes mate I'll take a look at it Monday.

I'm moving across to a new GH account so it'll be from this one.

Cheers,
Eric.

@photodude
Copy link

@digitalgarage did you ever have a chance to work on replicating this PR in the https://github.com/joomla-framework/form repo?

@ericfernance
Copy link

@photodude Hey Walt, no I didn't mainly as I found the CMS already had a colour picker (JFormFieldColor) I assumed this would be coming from JFW?

@photodude
Copy link

Ya, it's one of those FW vs CMS items. The CMS extends the FW and in some cases there is duplication of code. Technically I think the CMS has both the CMS form and the FW form.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants