fix: avoid infinite loop when resd is before resc #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an infinite loop when handling jpeg2000 files whose
resdbox is before therescbox. Theresdbox shares the format with therescbox, IMO we should prioritize theresdbox over therescbox. Anyway, I didn't touch this part in the PR.Such images are can be downloaded from the National Archives of Japan Digital Archive, for example, https://www.digital.archives.go.jp/gallery/0000000001.
I browsed through the
img2pdf_testand couldn't figure out how to write the test case, sinceimagemagickgenerally don't write theresdandrescboxes.I have attached a hand-crafted jpeg 2000 test file if that helps.
normal-with-resd-box.jp2.zip