Skip to content

Stringify for nums bigger than max safe integer #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 26, 2025
Merged

Stringify for nums bigger than max safe integer #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5aca165
Convert to string if number bigger than max safe int
pawfrolow Mar 11, 2025
a639d83
Changed contenteditable to plaintext-only to escape html paste
pawfrolow Mar 11, 2025
ef76e1f
Revert "Changed contenteditable to plaintext-only to escape html paste"
pawfrolow Mar 13, 2025
a2bf78e
add check for negative safe integer & unit tests
pawfrolow Mar 13, 2025
74188e8
add one more parseString unit test check
pawfrolow Mar 13, 2025
b4497fd
handling exponential numbers
pawfrolow Mar 13, 2025
bcd0e65
Merge branch 'josdejong:develop' into develop
pawfrolow Mar 13, 2025
cdd26b6
fix format
pawfrolow Mar 13, 2025
15dbeee
improve logic
pawfrolow Mar 21, 2025
ee5cdc7
lint
pawfrolow Mar 21, 2025
f3be85f
renamed hassymbols to isinteger
pawfrolow Mar 26, 2025
37ca40a
removed isinteger comment
pawfrolow Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/js/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,10 @@ export function parseString (str) {

const num = Number(str) // will nicely fail with '123ab'
const numFloat = parseFloat(str) // will nicely fail with ' '
if (!isNaN(num) && !isNaN(numFloat)) {
const isFiniteNumber = !isNaN(num) && !isNaN(numFloat) && isFinite(num)
const isInSafeRange = num <= Number.MAX_SAFE_INTEGER && num >= Number.MIN_SAFE_INTEGER
const isInteger = /^\d+$/.test(str)
if (isFiniteNumber && (isInSafeRange || !isInteger)) {
return num
}

Expand Down
63 changes: 36 additions & 27 deletions test/util.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,33 +305,42 @@ describe('util', () => {
})
})

it('should parse a string', () => {
assert.strictEqual(parseString('foo'), 'foo')
assert.strictEqual(parseString('234foo'), '234foo')
assert.strictEqual(parseString(' 234'), 234)
assert.strictEqual(parseString('234 '), 234)
assert.strictEqual(parseString('2.3'), 2.3)
assert.strictEqual(parseString('null'), null)
assert.strictEqual(parseString('true'), true)
assert.strictEqual(parseString('false'), false)
assert.strictEqual(parseString('+1'), 1)
assert.strictEqual(parseString('01'), '01')
assert.strictEqual(parseString('001'), '001')
assert.strictEqual(parseString('0.3'), 0.3)
assert.strictEqual(parseString('0e3'), 0)
assert.strictEqual(parseString(' '), ' ')
assert.strictEqual(parseString(''), '')
assert.strictEqual(parseString('"foo"'), '"foo"')
assert.strictEqual(parseString('"2"'), '"2"')
assert.strictEqual(parseString('\'foo\''), '\'foo\'')
assert.strictEqual(parseString('0x1A'), '0x1A')
assert.strictEqual(parseString('0x1F'), '0x1F')
assert.strictEqual(parseString('0x1a'), '0x1a')
assert.strictEqual(parseString('0b1101'), '0b1101')
assert.strictEqual(parseString('0o3700'), '0o3700')
assert.strictEqual(parseString('0X1a'), '0X1a')
assert.strictEqual(parseString('0B1101'), '0B1101')
assert.strictEqual(parseString('0O3700'), '0O3700')
describe('parseString', () => {
it('should parse a string', () => {
assert.strictEqual(parseString('foo'), 'foo')
assert.strictEqual(parseString('234foo'), '234foo')
assert.strictEqual(parseString(' 234'), 234)
assert.strictEqual(parseString('234 '), 234)
assert.strictEqual(parseString('2.3'), 2.3)
assert.strictEqual(parseString('null'), null)
assert.strictEqual(parseString('true'), true)
assert.strictEqual(parseString('false'), false)
assert.strictEqual(parseString('+1'), 1)
assert.strictEqual(parseString('01'), '01')
assert.strictEqual(parseString('001'), '001')
assert.strictEqual(parseString('0.3'), 0.3)
assert.strictEqual(parseString('0e3'), 0)
assert.strictEqual(parseString(' '), ' ')
assert.strictEqual(parseString(''), '')
assert.strictEqual(parseString('"foo"'), '"foo"')
assert.strictEqual(parseString('"2"'), '"2"')
assert.strictEqual(parseString('\'foo\''), '\'foo\'')
assert.strictEqual(parseString('0x1A'), '0x1A')
assert.strictEqual(parseString('0x1F'), '0x1F')
assert.strictEqual(parseString('0x1a'), '0x1a')
assert.strictEqual(parseString('0b1101'), '0b1101')
assert.strictEqual(parseString('0o3700'), '0o3700')
assert.strictEqual(parseString('0X1a'), '0X1a')
assert.strictEqual(parseString('0B1101'), '0B1101')
assert.strictEqual(parseString('0O3700'), '0O3700')
assert.strictEqual(parseString('7405242042266046865'), '7405242042266046865')
assert.strictEqual(parseString('9007199254740991'), 9007199254740991)
assert.strictEqual(parseString('9007199254740991'), 9007199254740991)
assert.strictEqual(parseString('-9007199254740991'), -9007199254740991)
assert.strictEqual(parseString('1e25'), 1e25)
assert.strictEqual(parseString('1e308'), 1e308)
assert.strictEqual(parseString('1e309'), '1e309')
})
})

it('should find a unique name', () => {
Expand Down