Skip to content

384 linter #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

384 linter #385

wants to merge 17 commits into from

Conversation

@walkerrandolphsmith
Copy link
Contributor

@walkerrandolphsmith walkerrandolphsmith commented Apr 16, 2017 •
edited
Loading

Working off of style guide in the CONTRIBUTING.md. This is tracked in issue #384

Items I commented the rule for because of many violations:

  1. Line length
  2. Equality operator
  3. Limit number of statements in single function

@walkerrandolphsmith
#384 Support eslint. No rules included.
463378f
@walkerrandolphsmith
#384 Enforce strict mode.
dd378fd
@walkerrandolphsmith
#384 Enforce 2 space indentation
e664f10
@walkerrandolphsmith
#384 Enforce use of semicolons
7001ad5
@walkerrandolphsmith
#384 Enfore no trailing whitespace
e20ce37
@walkerrandolphsmith
#384 Show how to enforce line legth limit of 80 characters. Do not en…
2222171 
…force the rule becasuse there are several violators.
@walkerrandolphsmith
#384 Enfore single quote strings
6a945a8
@walkerrandolphsmith
#384 Enforce braces on the same line. currently the average (mode) st…
05d3a89 
…yle used is Stroustrup.

Stroustrup: formatting where else statements in an if-else construct, as well as catch and finally, must be on its own line after the preceding closing brace
@walkerrandolphsmith
#384 Enforce one variable declaration per var statement.
8b1d0ca
@walkerrandolphsmith
#384 Enfore camelcase
cd5e905
@walkerrandolphsmith
#384 Enforce class names being capitalized with the exception of Ajv
ec70849
@walkerrandolphsmith
#384 Enfore using single quotes in object keys only when needed
2c2487c
@walkerrandolphsmith
#384 Enfore requiring a comma after and on the same line as an array …
3c9d1a4 
…element, object property, or variable declaration
@walkerrandolphsmith
#384 Show how to enfore === !=== equality comparators. Many violators…
8a4c6f5 
… made me decied to punt on enforcing strict equality comparators
@walkerrandolphsmith
#384 Enforce not extending prototype of native objects
41d1359
@walkerrandolphsmith
#384 Show how to enforce maximum number of statements in a single fun…
9b2765e 
…ction
@walkerrandolphsmith
#384 Ensure every rule throws an error instead of warning
5d342f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@walkerrandolphsmith