Skip to content

Conversation

@Lemeri123
Copy link
Collaborator

Screenshot from 2025-02-22 21-41-42
With this, the test coverage go above 60%

Successfully closes #81

@sonarqubecloud
Copy link

@Lemeri123
Copy link
Collaborator Author

@josdem help show me how I can refactor the lambda expression correctly

@josdem
Copy link
Owner

josdem commented Feb 22, 2025

@josdem help show me how I can refactor the lambda expression correctly

Hi @Lemeri123 , the fix is much easier, here are some things you should notice:

  1. MethodWrapper is an old class and it is not longer used in the code, therefore you can delete it.
  2. With that said the previous test is not required
  3. Finally seems like you do not have the latest version of the code, please notice these clases do not exist in the package dnd:
  • TransparencyManager
  • Jdk6u10TransparencyManager
  • NullTransparencyManager

Let me know if any questions.

@Lemeri123
Copy link
Collaborator Author

Wait so meaning even the tests for the method wrapper isnt needed since the method wrapper is no longer going to be in use??

@josdem
Copy link
Owner

josdem commented Feb 22, 2025

Wait so meaning even the tests for the method wrapper isnt needed since the method wrapper is no longer going to be in use??

Correct, seems like your branch does not have the latest changes from the main branch. Currently, we do not have any MethodWrapperusage in the project, therefore is perfectly right just to delete it. Good news, that will increase the coverage anyways in the util package.

@Lemeri123
Copy link
Collaborator Author

Ohh okay let me close this one then

@Lemeri123 Lemeri123 closed this Feb 23, 2025
@Lemeri123 Lemeri123 deleted the feat/79 branch February 23, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increment up to 60% coverage or more in util package

3 participants