Skip to content

[small]remoiving-unnused-methodWrapper-class #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josdem merged 2 commits into from
Feb 25, 2025
Merged

[small]remoiving-unnused-methodWrapper-class #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80151ff
Remoiving unnused MethodWrapper class
josdem Feb 23, 2025
f3f2b47
Updating version
josdem Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

group = 'com.josdem.jmetadata'
version = '1.3.8'
version = '1.3.9'

java {
toolchain {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/josdem/jmetadata/metadata/MetadataWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void setFile(File file) {
| TagException
| ReadOnlyFileException
| InvalidAudioFrameException nre) {
log.error(nre.getMessage(), nre);
throw new BusinessException(nre.getMessage());
}
}

Expand Down
143 changes: 0 additions & 143 deletions src/main/java/com/josdem/jmetadata/util/MethodWrapper.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/test/java/com/josdem/jmetadata/controller/CompleteControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import java.awt.Image;
import java.io.File;
import java.util.List;

import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/com/josdem/jmetadata/metadata/MetadataWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import com.josdem.jmetadata.util.ImageUtils;
import java.awt.Image;
import java.io.File;
import java.io.IOException;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.StringUtils;
import org.jaudiotagger.audio.AudioFile;
Expand Down Expand Up @@ -66,6 +67,15 @@ void setup() throws Exception {
metadataWriter.setFile(file);
}

@Test
@DisplayName("not setting file due to exception")
void shouldNotSetFile(TestInfo testInfo) throws Exception {
log.info(testInfo.getDisplayName());

doThrow(IOException.class).when(audioFileHelper).read(file);
assertThrows(BusinessException.class, () -> metadataWriter.setFile(file));
}

@Test
@DisplayName("writing artist")
void shouldWriteArtist(TestInfo testInfo) throws Exception {
Expand Down