[large]Feature/118 #133
Closed
[large]Feature/118 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
josdem
commented
Apr 21, 2025
josdem
commented
- Translate all helper tests to Kotlin
- Adding some injections using Lombok
- Updating version
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates various helper tests from Java to Kotlin, adds Lombok-based dependency injections to streamline object creation, and updates the version and related keys.
- Translated multiple test files from Java to Kotlin.
- Replaced field injections with Lombok's @requiredargsconstructor.
- Updated key values and introduced new production code enhancements.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/josdem/jmetadata/helper/ImageExporterTest.java | Removed in favor of Kotlin tests. |
| src/test/java/com/josdem/jmetadata/helper/FormatterHelperTest.kt | New Kotlin version of formatter tests. |
| src/test/java/com/josdem/jmetadata/helper/FormatterHelperTest.java | Removed Java formatter tests. |
| src/test/java/com/josdem/jmetadata/helper/ExporterHelperTest.kt | New Kotlin version of exporter tests. |
| src/test/java/com/josdem/jmetadata/helper/ExporterHelperTest.java | Removed Java exporter tests. |
| src/test/java/com/josdem/jmetadata/helper/AudioFileHelperTest.kt | New Kotlin version of audio file helper tests. |
| src/test/java/com/josdem/jmetadata/helper/AudioFileHelperTest.java | Removed Java audio file tests. |
| src/test/java/com/josdem/jmetadata/helper/ArtworkHelperTest.kt | New Kotlin version of artwork helper tests. |
| src/test/java/com/josdem/jmetadata/helper/ArtworkHelperTest.java | Removed Java artwork helper tests. |
| src/test/java/com/josdem/jmetadata/helper/ApplicationContextSingletonTest.kt | New Kotlin version of application context tests. |
| src/test/java/com/josdem/jmetadata/helper/ApplicationContextSingletonTest.java | Removed Java application context tests. |
| src/main/java/com/josdem/jmetadata/service/impl/LastFMCompleteServiceImpl.java | Updated to use Java Time APIs. |
| src/main/java/com/josdem/jmetadata/helper/ScrobblerHelper.java | Minor improvements including spelling fix and logging refactor. |
| src/main/java/com/josdem/jmetadata/helper/OutStreamWriter.java | Added Spring's @component annotation. |
| src/main/java/com/josdem/jmetadata/helper/MetadataExporter.java | Updated for Lombok and refactored collection access. |
| src/main/java/com/josdem/jmetadata/helper/LastFMTrackHelper.java | Added Spring's @component annotation. |
| src/main/java/com/josdem/jmetadata/helper/LastFMAuthenticator.java | Updated for Lombok constructor injection. |
| src/main/java/com/josdem/jmetadata/helper/LastFMAlbumHelper.java | Refactored date handling for year extraction. |
| src/main/java/com/josdem/jmetadata/helper/ExporterHelper.java | Updated for Lombok constructor injection. |
| src/main/java/com/josdem/jmetadata/Auth.java | Updated API key and secret values. |
Comment on lines
+67
to
+70
| if (metadataService.isSameAlbum(metadataList)) { | ||
| writer.write(metadataList.getFirst().getAlbum().getBytes()); | ||
| writer.write(BY.getBytes()); | ||
| writer.write(metadatas.get(0).getArtist().getBytes()); | ||
| writer.write(metadataList.getFirst().getArtist().getBytes()); |
There was a problem hiding this comment.
The method 'getFirst()' is not part of the standard java.util.List API; consider using 'get(0)' or another appropriate method to retrieve the first element.
|
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.