Add tests for ImageIconBase #97
Conversation
|
josdem
left a comment
josdem
left a comment
There was a problem hiding this comment.
Hi @Lemeri123 just small changes before merge, your collaboration is appreciated, you are doing a great job!
| when(imageIconBase.getImageIcon()).thenReturn(expectedImageIcon); | ||
|
|
||
| // When | ||
| ImageIcon result = imageIconBase.getImageIcon(); |
There was a problem hiding this comment.
This could be var result = imageIconBase.getImageIcon(); please change it
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ImageIconBaseTests { |
There was a problem hiding this comment.
Following name conventions this class should be named: ImageIconBaseTest please change it
|
I messed up on my local project and I rebased the branch mistakenly hence undoing all the local changes I made on this branch. So maybe we merge this and make the requested changes locally |
Hi @Lemeri123 , no problem I will merge as it is and we can make the changes later. |
|
Oh btw @josdem is this your working email address "[email protected]" |
That's my personal email address, this one is for business: [email protected], you can reach me in both address, no problem. |
|
Maybe you could have a look at your email. I sent you an email to your personal email |
Test methods:
testGetImageIcon: Tests the getImageIcon method to ensure it returns a non-null ImageIcon object and that the returned object matches the expected result.