Skip to content

Enforce UTF-8 arguments and ASCII for flags and commands - #11

Merged
joseluisq merged 2 commits into
masterfrom
enforce-utf-8-ascii-chars
Dec 30, 2025
Merged

joseluisq merged 2 commits into
masterfrom
enforce-utf-8-ascii-chars

Conversation

@joseluisq

@joseluisq joseluisq commented Dec 29, 2025 •

Copy link
Copy Markdown
Owner

This PR enforces UTF-8 arguments and ASCII with hyphens and digits for flags and commands.

Additionally, it fixes an issue where inconsistent use of aliases for special flags (version and help) was allowed (e.g. --v or --h).

@joseluisq joseluisq self-assigned this Dec 29, 2025
@semanticdiff-com

semanticdiff-com Bot commented Dec 29, 2025 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  handler/handler.go  37% smaller
  handler/handler_test.go  10% smaller
  helpers/helpers.go  10% smaller
  helpers/helpers_test.go  0% smaller

@codecov

codecov Bot commented Dec 29, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.41%. Comparing base (8a2491a) to head (15c964e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   97.52%   98.41%   +0.88%     
==========================================
  Files           8        8              
  Lines         769      819      +50     
==========================================
+ Hits          750      806      +56     
+ Misses         15       11       -4     
+ Partials        4        2       -2     
Flag Coverage Δ
unittests 98.41% <100.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joseluisq
joseluisq force-pushed the enforce-utf-8-ascii-chars branch from 47d0e31 to e635700 Compare December 30, 2025 02:46
@joseluisq joseluisq added enhancement New feature or request bugfix labels Dec 30, 2025
@joseluisq
joseluisq marked this pull request as ready for review December 30, 2025 03:13
@joseluisq
joseluisq merged commit 5a2012d into master Dec 30, 2025
17 checks passed
@joseluisq
joseluisq deleted the enforce-utf-8-ascii-chars branch December 30, 2025 03:14
@joseluisq joseluisq added this to the v1.0.0 milestone Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant