Conversation
Collaborator
namvdo
commented
Sep 18, 2025
- Add a button to jump to the active image pane
- Add a pulldown menu containing available image panes.
joyhughes
reviewed
Oct 5, 2025
Owner
Owner
joyhughes
requested changes
Oct 15, 2025
joyhughes
requested changes
Nov 26, 2025
| const activeImage = getActiveImage(); | ||
|
|
||
| // Determine if the active image is source or target based on widget name | ||
| const getImageLabel = () => { |
Owner
There was a problem hiding this comment.
Remove the functions below. All image pickers should be handled the same as any other widget. They should use the same font as other widgets, with the name of the widget followed by the thumbnail.
Clicking on thumbnail should go to image pane.
// Determine if the active image is source or target based on widget name
const getImageLabel = () => {
if (!activeImage) return "Images";
const widgetName = activeImage.name.toLowerCase();
if (widgetName.includes('source')) return "Source Image";
if (widgetName.includes('target')) return "Target Image";
return "Images";
};
// Filter out any group that has image picker widgets for the Home pane
const nonImageGroups = activeGroups.filter(group => {
// For groups, check if they have image pickers
if (group.widgets) {
const hasImageWidget = group.widgets.some(widgetName => {
try {
const widgetJSON = window.module?.get_widget_JSON(widgetName);
const widget = JSON.parse(widgetJSON);
return widget?.tool === 'image';
} catch (error) {
return false;
}
});
return !hasImageWidget;
}
return true;
});
| minWidth: 'auto' | ||
| }} | ||
| > | ||
| <Box sx={{ |
Owner
There was a problem hiding this comment.
Remove the following section. Image picker should be handled like other widgets.
display: 'flex',
alignItems: 'center',
gap: 1
}}>
<Typography variant="body2" sx={{ fontWeight: 500 }}>
{getImageLabel()}
</Typography>
{activeImage && (
<Box
sx={{
width: 32,
height: 32,
borderRadius: 0.5,
border: '1px solid',
borderColor: 'primary.main',
boxShadow: 1,
overflow: 'hidden',
flexShrink: 0
}}
>
<ThumbnailCanvas
imageName={activeImage.path}
width={32}
height={32}
setStatus={setThumbnailStatus}
/>
</Box>
)}
</Box>
Owner
|
In widget_group.jsx line 115, no longer disable image widgets. Include the name of the widget and thumbnail, click takes to image pane. |
Collaborator
Author
|
Please take a look at: #282 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




