chore(docs): update documentations on leeway #1101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thank you for the great library!
I made this PR as I was having some troubles navigating around the documentation. For the context:
iat
that are faster than my server time.leeway
property, but got confused as in "does this library support it or not?"leeway
only exists fornbf
andexp
, so I was thinking "oh, then,leeway
doesn't work foriat
"_validate_iat
actually does! (see appendix A)leeway
is only forexpiration
which might be misleading.See appendix B for the screenshots of the updated documentation.
Apologies for any mistakes if I'm contributing the wrong way (do I need to create an issue first, etc.) - this is my first time contributing to one. This PR was mostly inspired by #1034 which adds documentation for
nbf
.Appendix A
Appendix B