Skip to content

Conversation

@klemensn
Copy link
Contributor

As of today's HEAD, this produces psst-gui that at least starts and
prompts for account details, on OpenBSD/amd64 7.3 -current with
gtk+3-3.24.38 cairo-1.17.8p0 llvm-13.0.0p5

@klemensn
Copy link
Contributor Author

#191 is still an ongoing effort, but this would've helped me to get started again when coming back to it after two years.

Copy link
Collaborator

@Insprill Insprill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear you're still working on BSD support!

There should be a disclaimer that BSD support is still a WIP, and isn't ready to be used yet.

The code block related to building is also a little tricky to understand. It should be separated out into individual commands/results instead of grouping it all together.

@klemensn
Copy link
Contributor Author

Glad to hear you're still working on BSD support!

There should be a disclaimer that BSD support is still a WIP, and isn't ready to be used yet.

The code block related to building is also a little tricky to understand. It should be separated out into individual commands/results instead of grouping it all together.

Is this any better?

Copy link
Collaborator

@Insprill Insprill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the slow review. I just have one last nitpick

As of today's HEAD, this produces `psst-gui` that at least starts and
prompts for account details, on OpenBSD/amd64 7.3 -current with
gtk+3-3.24.38 cairo-1.17.8p0 llvm-13.0.0p5
Copy link
Collaborator

@Insprill Insprill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Insprill Insprill merged commit 56fae74 into jpochyla:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants