Allow an optional context when using dive #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
reviewed
Jan 19, 2025
garde/tests/rules/dive_with_ctx.rs
Outdated
| min: usize, | ||
| #[garde(skip)] | ||
| max: usize, | ||
| #[garde(dive(&(self.min, self.max)))] |
There was a problem hiding this comment.
This should probably not require the &, and instead always prefix the #ctx with & in emit, because context is always passed by reference. What do you think?
There was a problem hiding this comment.
That seems right! I've just updated the PR
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #142
The macro is backwards-compatible, so it just requires a minor version update.