#1413: Handle "+" character in file paths#1414
Open
baxter-huntington wants to merge 1 commit into
Open
Conversation
URLDecoder.decode applies the application/x-www-form-urlencoded MIME format, which includes converting "+" characters to space characters. If a path contains "+" characters, upon re-encoding, they will be converted to %20 instead of %2b, yielding a different file path than we started with. We handle this by converting "+" to "%2b" before decoding to ensure that it is preserved across the round trip.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
- Coverage 86.24% 86.17% -0.07%
==========================================
Files 112 112
Lines 10289 10289
Branches 4056 4056
==========================================
- Hits 8874 8867 -7
- Misses 809 814 +5
- Partials 606 608 +2 🚀 New features to boost your workflow:
|
Contributor
|
Seems very reasonable, though we will likely need to improve it a bit before inclusion.
AI states this is likely needed.
I can generate those for you when I have development cycles free. Or you can add it and we can skip straight to review. Thanks for the contribution! |
Author
|
@Thrameos I appreciate the quick look and response 😃 I'd be happy to address those items. I should have some time to get to them tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLDecoder.decodeapplies theapplication/x-www-form-urlencodedMIME format, which includes converting "+" characters to space characters. If a path contains "+" characters, upon re-encoding, they will be converted to%20instead of%2b, yielding a different file path than we started with.We handle this by converting "+" to "%2b" before decoding to ensure that it is preserved across the round trip.
Resolves: #1413