Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Update .travis.yml #8648

Merged
merged 7 commits into from
Jun 14, 2019
Merged

Update .travis.yml #8648

merged 7 commits into from
Jun 14, 2019

Conversation

ecadius
Copy link
Contributor

@ecadius ecadius commented Apr 29, 2019

The builds should run now. refs: #8639 #8618 #8617 #8245

@ecadius
Copy link
Contributor Author

ecadius commented May 8, 2019

What has time changed that they don't run anymore? I don't get it. 3 Months ago the build passed: https://travis-ci.com/ecadius/jquery-mobile/builds/99162130

@ecadius ecadius mentioned this pull request May 13, 2019
ecadius added 3 commits June 13, 2019 18:41
Consistent testing method which is described in the ReadMe.
use ubuntu 16.04
update php version
.travis.yml Outdated

script: npm run-script ci
script: npm run-script test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we don't need to change this.

Copy link
Contributor Author

@ecadius ecadius Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ReadMe describes the test process with npm run-script test. What is the purpose of npm run-script ci?

.travis.yml Outdated
@@ -1,21 +1,21 @@
language: php

php:
- "5.5"
- "7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, @arschmitz used to say that there were some issues in upgrading to PHP 7.0.

@apsdehal
Copy link
Contributor

Can you retrigger the build by pushing a commit?

set php version back to 5.5
@ecadius
Copy link
Contributor Author

ecadius commented Jun 14, 2019

I reseted the php version back to 5.5. Perhaps the travis tests will pass, but they are a bit random and i simple try to rebuild my local environment which passed all tests.

ecadius added 2 commits June 14, 2019 17:37
longer timeouts for the tests
@apsdehal
Copy link
Contributor

Only one of the tests' suites is failing, we can figure that one later (has some issue related to phatomjs). Squashing and merging this one for now. Thanks.

@apsdehal apsdehal merged commit 4a6395d into jquery-archive:master Jun 14, 2019
@mgol
Copy link
Contributor

mgol commented Dec 9, 2019

@apsdehal The issue at https://travis-ci.org/jquery/jquery-mobile/jobs/545864736 is not related to PhantomJS in particular but to the usage of jQuery.isArray which has been removed on jQuery master and will not be in jQuery 4.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants