Build: Skip checking oembed wp-json links in the hydra crawler #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The remaining failure is legitimate and I'm fixing it in jquery/jquery-wp-content#482. Please approve that other PR and I can re-run the check here before merging. |
|
Looks like Google is having issues. About 1 in 10 times reproducible locally with curl. Ha! |
The oembed endpoint responds HTTP 429 Too Many Requests too often; perhaps because almost every page links to one. Also, run the spider check on PRs that modify the hydra config file.
|
@Krinkle all green now. |
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Apr 14, 2025
Change the html5shiv link from https://code.google.com/p/html5shiv/ to https://github.com/afarkas/html5shiv to which the former already 301-redirects. We've had some code.google.com-related spider-check crawler errors which this may also eliminate. Ref jquerygh-1275
@Krinkle This link already 301-redirects to GitHub so I updated it in PR #1276, PTAL. |
Krinkle
pushed a commit
that referenced
this pull request
Apr 14, 2025
Change the html5shiv link from https://code.google.com/p/html5shiv/ to https://github.com/afarkas/html5shiv to which the former already 301-redirects. We've had some code.google.com-related spider-check crawler errors which this may also eliminate. Ref gh-1275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oembed endpoint responds HTTP 429 Too Many Requests too often; perhaps because almost every page links to one.