Skip to content

Add eslint, upgrade dependencies, add "Publishing Plugins to npm" page #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add eslint, upgrade dependencies, add "Publishing Plugins to npm" page #818

merged 2 commits into from
Apr 11, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Apr 9, 2024 •
edited
Loading

Ref jquery/infrastructure-puppet#29

  • Added a new page on how to publish jQuery plugins to npm
  • Updated dependencies and added eslint so the JS in the Gruntfile could be auto-formatted
  • Using a symlink for contributing.md wasn't working on Windows. I switched this to use @partial instead and the resulting HTML is the same.
  • Updated .editorconfig to match what was already in the repo (all JSON files were using spaces despite only package.json being specified)

@timmywil timmywil requested a review from Krinkle April 9, 2024 17:27
@timmywil timmywil mentioned this pull request Apr 9, 2024
Closed
5 tasks
This was referenced Apr 9, 2024
Closed
Closed
Closed
@timmywil
Copy link
Member Author

timmywil commented Apr 9, 2024

Fixed conflict

@timmywil timmywil requested a review from mgol April 9, 2024 19:49
mgol
mgol reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but looks good overall!

mgol
mgol reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left to address

@timmywil timmywil merged commit 5833d53 into jquery:main Apr 11, 2024
1 check passed
@timmywil timmywil deleted the plugin-author branch April 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol left review comments

@Krinkle Krinkle Krinkle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timmywil @Krinkle @mgol