Use encoding and CR-aware concatenation #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `cat` method used here does not consider encodings or code ranges, instead just slamming the given bytes directly into the existing buffer. This causes problem when those bytes or the encoding they came from does not match the existing encoding or code range, leading to issues like jruby#247. The fix here uses a code range-aware method for doing the bytes concatenation, and resolved the related bug. Fixes jruby#247
headius
force-pushed
the
encoding_aware_cat
branch
from
61ca365 to
3319527
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
catmethod used here does not consider encodings or code ranges, instead just slamming the given bytes directly into the existing buffer. This causes problem when those bytes or the encoding they came from does not match the existing encoding or code range, leading to issues like #247.The fix here uses a code range-aware method for doing the bytes concatenation, and resolved the related bug.
Fixes #247