Skip to content

Conversation

teplostanski
Copy link
Contributor

@teplostanski teplostanski commented Sep 20, 2025

The site content is documentation for the vite plugin vite-plugin-readable-classnames.

The CNAME file is correctly set up here:
https://github.com/teplostanski/vite-plugin-readable-classnames/blob/main/docs/public/CNAME

2025-09-20 13 39 56 localhost 3b056d6cc498

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@teplostanski
Copy link
Contributor Author

@MattIPv4 Hi,

Thank you for the feedback. I have inserted my requested subdomain "vite-plugin-readable-classnames": "teplostanski.github.io/vite-plugin-readable-classnames" in the correct alphabetical order relative to the existing entries.

I believe the ordering issues flagged by the check are caused by other entries in the file that are out of order, not by my addition. If possible, could you please advise how best to proceed given this situation?

@MattIPv4
Copy link
Member

No, your entry is in the wrong location, as you can see by the errors output from the check.

image

vite- sorts before vited.

@teplostanski
Copy link
Contributor Author

@MattIPv4 Fixed

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/teplostanski/vite-plugin-readable-classnames/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed invalid labels Sep 20, 2025
@indus
Copy link
Member

indus commented Sep 20, 2025

@indus indus merged commit a81ec73 into js-org:master Sep 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants