-
Notifications
You must be signed in to change notification settings - Fork 36
Port test suite to Jest #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These were accidentally added in a previous rebase.
These have been removed upstream, probably because of having been converted into test262 tests already and using temporal-test262-runner. They were missed in the rebases.
ecfb1ba to
99e600c
Compare
|
Unfortunately I've run out of time for this without getting it to work Jest's "resolver" option doesn't seem to work properly on Node 20.x and earlier. Here's the error: The file that it claims not to find is right there, so I'm not sure what's going on. It also works on my machine, even with a copy of Node 18. Hopefully someone else can take this and run with it! |
|
I can reproduce the issue when running
|
|
Thanks, that fixed Node 18.x and 20.x, but there is still the same error on 16.x, and a different error on 14.x. |
|
Jest v30 supports only Node.js v18 and later, so I think there are two options: use older Jest v29 which supports Node.js v14 and v16, or stop testing for EOL versions (v14, v16). |
Drop the obsolete Demitasse dependency. Rather than convert every single test to use Jest's expect-style assertions, write simple wrappers for assert(), throws(), etc. The idea is to use the Jest-style assertions in new code but the existing code can be left alone.
To generate this commit I installed node@18 with Homebrew and ran `npm install --package-lock-only`.
|
That did it, thank you @fabon-f! This is ready for merging now, I think. |
justingrant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Nice work making this happen.
|
Thanks for the review. |
This is something we've been talking about for a while. I started doing it for the upstream reference polyfill, but abandoned it because Jest was too memory-heavy to support the number of snapshot tests I wanted to do. However, that work was mostly reusable for this polyfill.