Implement `.text` property for HTMLScriptElement #390

Copilot · 2025-10-11T02:43:12Z

Summary

Successfully implemented the .text property on HTMLScriptElement according to the HTML Standard specification. The implementation:

Getter: Returns the child text content of the element by recursively collecting data from all Text and CDATA node descendants in tree order, as defined in the DOM spec
Setter: Replaces the element's children with the text given by value
Proprietary Implementation: Uses a dedicated recursive traversal function specific to HTMLScriptElement, distinguished from the generic textContent logic
Spec Compliance: Follows the WHATWG specification and mainstream browser implementations

Key Fix

The implementation now correctly traverses all descendants (not just direct children) to collect text from nested elements. For example:

<script>
  before 
  <div><span>span1</span><span> span2</span></div>
   after
</script>

The .text property correctly returns "before span1 span2 after", collecting text from all descendants in tree order.

Testing

The test fixture (renamed to htmlscriptelement-text.html) includes:

Getting text from normal, module, and empty script elements
Setting text via the .text property
Multiple text nodes with comments (verifying comments are ignored)
Nested elements with text (verifying all descendants are collected)
Indirect child nodes (deeply nested text in tree order)
Single text node optimization

All tests verify that .text correctly implements the "child text content" concept from the DOM spec.

<issue_title><script> element does not support .text property to get content</issue_title>

Fixes #389

Original prompt

This section details on the original issue you should resolve

<issue_title><script> element does not support .text property to get content</issue_title>
<issue_description>## Bug Description

Currently, in JSAR Runtime, the <script> element does not support the .text property to retrieve its content. For example, with the following HTML snippet:
<script id="normalScript" type="text/javascript">
  const a = 1;
</script>
Attempting to get the script content using JavaScript:
const normalScript = document.getElementById("normalScript").text;
console.log(normalScript); // Expected: "\n  const a = 1;\n"
The .text property should return the textual content inside the <script> tag, as defined in the HTML Standard. This is supported in major browsers (Chromium, Gecko, WebKit).

Expected Behavior

element.text returns the content inside the <script> tag as a string.

Actual Behavior

element.text is undefined or not implemented.

Reference

HTML Standard: dom-script-text

Chromium implementation: HTMLScriptElement::text

Gecko implementation: nsIScriptElement::GetScriptText

Suggested Fix

Implement the .text property on HTMLScriptElement so that it returns the content of the script element.

Example
<script id="normalScript" type="text/javascript">
  const a = 1;
</script>
<script>
  const normalScript = document.getElementById("normalScript").text;
  console.log(normalScript); // Should log: "\n  const a = 1;\n"
</script>
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #389

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

EndlessJour9527 · 2025-10-11T03:28:41Z

src/client/html/html_script_element.hpp

+    inline string getText() const
+    {
+      return textContent();
+    }
+    inline void setText(const string &value)
+    {
+      setTextContent(value);
+    }


@copilot script.text [ = value ]
Returns the child text content of the element.

script.text = value
Replaces the element's children with the text given by value.

Added spec references to the implementation. The getter returns the child text content of the element and the setter replaces the element's children with the given text value, as specified in the HTML Standard. (commit aaf3f10)

@copilot
The .text property is a proprietary property of the HTMLScriptElement and behaves similarly to .textContent, but not exactly the same.

It is recommended to provide a .text accessor specifically for the HTMLScriptElement and to distinguish it from the textContent logic.

Refer to the browser mainstream implementation and the WHATWG specification to ensure semantics and compatibility.

Implemented a dedicated .text accessor specifically for HTMLScriptElement with proper child text content traversal. The implementation now recursively collects text from all Text node descendants (not just direct children), ensuring full compliance with the WHATWG spec and browser behavior. (commit c51cab8)

Copilot

Pull Request Overview

This PR implements the .text property for HTMLScriptElement to provide spec-compliant access to script element content, addressing a missing feature that broke compatibility with standard browsers.

Added getter/setter methods for the .text property with optimized text node traversal
Implemented JavaScript bindings to expose the property to web content
Created comprehensive test coverage for various script element scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/client/html/html_script_element.hpp	Added getText() and setText() method declarations
src/client/html/html_script_element.cpp	Implemented optimized getText() with fast path for single text nodes and setText() stub
src/bindings/dom/html_script_element.hpp	Added TextGetter and TextSetter binding method declarations
src/bindings/dom/html_script_element.cpp	Implemented JavaScript property bindings for the text accessor
fixtures/html/script-text-property-test.html	Added comprehensive test fixture covering getter/setter scenarios

Copilot · 2025-10-11T08:31:14Z

src/client/html/html_script_element.cpp

+    //TODO: Replaces the element's children with the text given by value.
+    // https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
+    assert(false && "Function not yet implemented!");


The setText method is not implemented but is exposed through JavaScript bindings. This will cause a runtime assertion failure when users try to set the text property, breaking the API contract.

Suggested change

//TODO: Replaces the element's children with the text given by value.

// https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text

assert(false && "Function not yet implemented!");

// Replaces the element's children with a single text node containing value.

// https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text

// Remove all existing children

while (!childNodes.empty()) {

removeChild(childNodes.front());

}

// Create a new text node and append it as the only child

if (!value.empty()) {

auto doc = ownerDocument->lock();

auto textNode = doc->createTextNode(value);

appendChild(textNode);

}

src/client/html/html_script_element.cpp

EndlessJour9527 · 2025-10-13T03:03:09Z

Please add a case of an indirect child node and let me verify The spec reference mentions collecting text from 'all Text and CDATA node descendants in tree order @copilot

Copilot · 2025-10-13T03:07:40Z

Please add a case of an indirect child node and let me verify The spec reference mentions collecting text from 'all Text and CDATA node descendants in tree order @copilot

Added test case for indirect child nodes at lines 116-141 in the test fixture. The test creates a structure with nested <div> and <span> elements containing text, verifying that .text correctly collects text from all descendants in tree order: "before span1 span2 after". The implementation now properly uses recursive traversal to collect text from all Text and CDATA node descendants, not just direct children. (commit pending)

Please add a case of an indirect child node and let me verify The spec reference mentions collecting text from 'all Text and CDATA node descendants in tree order @copilot

Added test case for indirect child nodes at lines 116-141 in the test fixture. The test creates a structure with nested <div> and <span> elements containing text, verifying that .text correctly collects text from all descendants in tree order: "before span1 span2 after". The implementation now properly uses recursive traversal to collect text from all Text and CDATA node descendants, not just direct children. (commit d460157)

src/client/html/html_script_element.cpp

Co-authored-by: EndlessJour9527 <[email protected]>

…ild text content traversal Co-authored-by: EndlessJour9527 <[email protected]>

… and performance

…add a placeholder for setText implementation

… improved efficiency

…setter methods

…clarity

yorkie

@copilot @EndlessJour9527 Updated.

yorkie · 2025-10-27T06:38:54Z

src/client/html/html_script_element.cpp

@@ -1,5 +1,6 @@
 #include <algorithm>
 #include <iostream>
+#include <limits>


Remove this #include

Removed the #include <limits> line from html_script_element.cpp.

yorkie · 2025-10-27T06:40:29Z

fixtures/html/htmlscriptelement-text.html

Rename to htmlscriptelement-text.html

Renamed the test file from script-text-property-test.html to htmlscriptelement-text.html.

…text.html Co-authored-by: yorkie <[email protected]>

Copilot AI assigned Copilot and EndlessJour9527 Oct 11, 2025

Copilot started work on behalf of EndlessJour9527 October 11, 2025 02:43 View session

Copilot AI changed the title ~~[WIP] Fix script element text property to support content retrieval~~ Implement .text property for HTMLScriptElement Oct 11, 2025

Copilot AI requested a review from EndlessJour9527 October 11, 2025 02:53

Copilot finished work on behalf of EndlessJour9527 October 11, 2025 02:53

EndlessJour9527 reviewed Oct 11, 2025

View reviewed changes

Copilot started work on behalf of EndlessJour9527 October 11, 2025 03:29 View session

Copilot AI requested a review from EndlessJour9527 October 11, 2025 03:33

Copilot finished work on behalf of EndlessJour9527 October 11, 2025 03:33

Copilot started work on behalf of EndlessJour9527 October 11, 2025 06:11 View session

Copilot finished work on behalf of EndlessJour9527 October 11, 2025 06:15

EndlessJour9527 requested a review from Copilot October 11, 2025 08:30

Copilot AI reviewed Oct 11, 2025

View reviewed changes

Copilot started work on behalf of EndlessJour9527 October 13, 2025 02:32 View session

Copilot finished work on behalf of EndlessJour9527 October 13, 2025 02:33

Copilot started work on behalf of EndlessJour9527 October 13, 2025 03:04 View session

Copilot finished work on behalf of EndlessJour9527 October 13, 2025 03:08

EndlessJour9527 force-pushed the copilot/fix-script-element-text-property branch from d460157 to bf25a6e Compare October 13, 2025 06:40

EndlessJour9527 marked this pull request as ready for review October 14, 2025 06:30

yorkie requested changes Oct 16, 2025

View reviewed changes

src/client/html/html_script_element.cpp Outdated Show resolved Hide resolved

Copilot AI and others added 7 commits October 27, 2025 11:20

Initial plan

ceb2279

Implement .text property for HTMLScriptElement

9698751

Co-authored-by: EndlessJour9527 <[email protected]>

Add spec references to .text property implementation

243c1c2

Co-authored-by: EndlessJour9527 <[email protected]>

Implement dedicated .text getter for HTMLScriptElement with proper ch…

11d6956

…ild text content traversal Co-authored-by: EndlessJour9527 <[email protected]>

Enhance HTMLScriptElement.text getter for improved text node handling…

6d321aa

… and performance

Enhance HTMLScriptElement.getText to include CDATA section nodes and …

eff88a8

…add a placeholder for setText implementation

Refactor HTMLScriptElement.getText to return textContent directly for…

d030e82

… improved efficiency

EndlessJour9527 force-pushed the copilot/fix-script-element-text-property branch from d10eb46 to d030e82 Compare October 27, 2025 04:04

EndlessJour9527 added 2 commits October 27, 2025 12:05

Refactor HTMLScriptElement text handling to use dedicated getter and …

6d15269

…setter methods

Refactor HTMLScriptElement text handling methods for consistency and …

0cc2e07

…clarity

yorkie requested changes Oct 27, 2025

View reviewed changes

Copilot started work on behalf of yorkie October 27, 2025 06:41 View session

Remove unnecessary include and rename test file to htmlscriptelement-…

d2762e2

…text.html Co-authored-by: yorkie <[email protected]>

Copilot finished work on behalf of yorkie October 27, 2025 06:47

Copilot AI requested a review from yorkie October 27, 2025 06:47

fix

7704462

yorkie approved these changes Nov 3, 2025

View reviewed changes

update

972492a

yorkie merged commit 542b3ea into main Nov 3, 2025
2 checks passed

yorkie deleted the copilot/fix-script-element-text-property branch November 3, 2025 09:14

-    //TODO: Replaces the element's children with the text given by value.
-    // https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
-    assert(false && "Function not yet implemented!");
+    // Replaces the element's children with a single text node containing value.
+    // https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
+    // Remove all existing children
+    while (!childNodes.empty()) {
+      removeChild(childNodes.front());
+    }
+    // Create a new text node and append it as the only child
+    if (!value.empty()) {
+      auto doc = ownerDocument->lock();
+      auto textNode = doc->createTextNode(value);
+      appendChild(textNode);
+    }

Implement .text property for HTMLScriptElement #390

Implement .text property for HTMLScriptElement #390

Uh oh!

Conversation

Copilot AI commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Fix

Testing

Expected Behavior

Actual Behavior

Reference

Suggested Fix

Example

Comments on the Issue (you are @copilot in this section)

Uh oh!

EndlessJour9527 Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

EndlessJour9527 Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EndlessJour9527 commented Oct 13, 2025

Uh oh!

Copilot AI commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yorkie left a comment

Choose a reason for hiding this comment

Uh oh!

yorkie Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

yorkie Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implement `.text` property for HTMLScriptElement #390

Implement `.text` property for HTMLScriptElement #390

Copilot AI commented Oct 11, 2025 •

edited

Loading

Copilot AI commented Oct 13, 2025 •

edited

Loading