Skip to content

WebGL2: Implement gl.getParameter(gl.UNIFORM_BUFFER_OFFSET_ALIGNMENT) #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yorkie merged 4 commits into from
Nov 21, 2025
Merged

WebGL2: Implement gl.getParameter(gl.UNIFORM_BUFFER_OFFSET_ALIGNMENT) #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94a1e96
Initial plan
Copilot Nov 17, 2025
e7bb3f8
Add support for gl.getParameter(gl.UNIFORM_BUFFER_OFFSET_ALIGNMENT)
Copilot Nov 17, 2025
289aa5e
feat(webgl): add support for WEBGL2_UNIFORM_BUFFER_OFFSET_ALIGNMENT
EndlessJour9527 Nov 18, 2025
5ad9e58
fix format
EndlessJour9527 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/client/graphics/webgl_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,6 +1646,7 @@ namespace endor
maxServerWaitTimeout = initResp->maxServerWaitTimeout;
maxUniformBlockSize = initResp->maxUniformBlockSize;
maxTextureLODBias = initResp->maxTextureLODBias;
uniformBufferOffsetAlignment = initResp->uniformBufferOffsetAlignment;

// Extensions
OVR_maxViews = initResp->OVR_maxViews;
Expand Down Expand Up @@ -2023,6 +2024,8 @@ namespace endor
return maxUniformBlockSize;
else if (pname == WebGL2IntegerParameterName::kMaxTextureLodBias)
return maxTextureLODBias;
else if (pname == WebGL2IntegerParameterName::kUniformBufferOffsetAlignment)
return uniformBufferOffsetAlignment;
else if (pname == WebGL2IntegerParameterName::kExtMaxViewsOvr)
return OVR_maxViews;

Expand Down
2 changes: 2 additions & 0 deletions src/client/graphics/webgl_context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ namespace endor
kMaxServerWaitTimeout = WEBGL2_MAX_SERVER_WAIT_TIMEOUT,
kMaxUniformBlockSize = WEBGL2_MAX_UNIFORM_BLOCK_SIZE,
kMaxTextureLodBias = WEBGL2_MAX_TEXTURE_LOD_BIAS,
kUniformBufferOffsetAlignment = WEBGL2_UNIFORM_BUFFER_OFFSET_ALIGNMENT,
kExtMaxViewsOvr = WEBGL2_EXT_MAX_VIEWS_OVR,
};

Expand Down Expand Up @@ -1027,6 +1028,7 @@ namespace endor
int64_t maxServerWaitTimeout;
int64_t maxUniformBlockSize;
float maxTextureLODBias;
int uniformBufferOffsetAlignment;

public: // Extension properties
int32_t OVR_maxViews;
Expand Down
1 change: 1 addition & 0 deletions src/client/script_bindings/webgl/webgl_rendering_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4422,6 +4422,7 @@ namespace endor
case WEBGL2_MAX_SERVER_WAIT_TIMEOUT:
case WEBGL2_MAX_UNIFORM_BLOCK_SIZE:
case WEBGL2_MAX_TEXTURE_LOD_BIAS:
case WEBGL2_UNIFORM_BUFFER_OFFSET_ALIGNMENT:
case WEBGL2_EXT_MAX_VIEWS_OVR:
{
auto value = handle<client_graphics::WebGL2Context>()
Expand Down
2 changes: 2 additions & 0 deletions src/common/command_buffers/details/webgl_context_init.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ namespace commandbuffers
, maxServerWaitTimeout(that.maxServerWaitTimeout)
, maxUniformBlockSize(that.maxUniformBlockSize)
, maxTextureLODBias(that.maxTextureLODBias)
, uniformBufferOffsetAlignment(that.uniformBufferOffsetAlignment)
// Extensions
, OVR_maxViews(that.OVR_maxViews)
, maxTextureMaxAnisotropy(that.maxTextureMaxAnisotropy)
Expand Down Expand Up @@ -217,6 +218,7 @@ namespace commandbuffers
int64_t maxServerWaitTimeout;
int64_t maxUniformBlockSize;
float maxTextureLODBias;
int uniformBufferOffsetAlignment;

public: // Extensions
int32_t OVR_maxViews;
Expand Down
1 change: 1 addition & 0 deletions src/renderer/render_api_opengles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ class RHI_OpenGL : public TrRenderHardwareInterface
glGetIntegerv(GL_MAX_VERTEX_OUTPUT_COMPONENTS, &res.maxVertexOutputComponents);
glGetIntegerv(GL_MAX_VERTEX_UNIFORM_BLOCKS, &res.maxVertexUniformBlocks);
glGetIntegerv(GL_MAX_VERTEX_UNIFORM_COMPONENTS, &res.maxVertexUniformComponents);
glGetIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT, &res.uniformBufferOffsetAlignment);
// GLint64 values
glGetInteger64v(GL_MAX_COMBINED_FRAGMENT_UNIFORM_COMPONENTS, &res.maxCombinedFragmentUniformComponents);
glGetInteger64v(GL_MAX_SERVER_WAIT_TIMEOUT, &res.maxServerWaitTimeout);
Expand Down