feat: implement Windows file path handling in URL parsing #304
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Per @annevk's guidance in whatwg/url#874, the implementation is now Implementation SummaryCore Rules (Implemented):
Test Results:
Changes Made:
WPT Tests: Updated in web-platform-tests/wpt#53459 Ready for review! 🚀 |
- Single ASCII letter + :\ → Windows file path - Multi-letter drives (CC:\, ABC:\) → Failure - Non-letter drives (1:\, @:\) → Failure - Normal schemes with backslash → Opaque path (valid) Per @annevk's feedback in whatwg/url#874
- Add 'u' flag to all regex patterns - Use template literals instead of string concatenation - Fix whitespace before property access
mertcanaltin
added a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 18, 2025
Updated tests to reflect simplified Windows path handling: 1. Multi-letter drives (CC:\, ABC:\) are now parsed as normal URLs - CC:\path → scheme: cc, path: \path (not failure) - 1:\path → failure (schemes must start with ASCII letter) - @:\path → failure (@ not valid in scheme) 2. UNC paths without base URL should fail - \\server\share → failure (no special UNC handling) - UNC paths with file: base still work via relative parsing This aligns with whatwg/url#874 guidance: "Why would we not parse CC:\path as we do today?" Only single ASCII letter + :\ should be treated as Windows file path. Everything else uses normal URL parsing. Related: whatwg/url#874, jsdom/whatwg-url#304
domenic
requested changes
Oct 19, 2025
| ] | ||
| .map(async file => { | ||
| const res = await fetch(`${urlPrefix}${file}`); | ||
| await fs.writeFile(path.resolve(targetDir, file), res.body); |
domenic
requested changes
Oct 19, 2025
| // Only convert single ASCII letter + :\ pattern (e.g., C:\, D:\) | ||
| // Note: Only backslash (\), not forward slash (/) | ||
| // Everything else goes through normal URL parsing | ||
| if (!stateOverride && !this.url.scheme && /^[a-zA-Z]:\\/u.test(this.input)) { |
There was a problem hiding this comment.
This doesn't match the spec text at https://github.com/whatwg/url/pull/874/files#diff-29243b3b9b716b55c6a61970b0c4864f464b139d397fb961a05bb6e1e2b97cabR2251 . Please translate the spec text directly.
| // Handle Windows file paths if no state override | ||
| // Only convert single ASCII letter + :\ pattern (e.g., C:\, D:\) | ||
| // Note: Only backslash (\), not forward slash (/) | ||
| // Everything else goes through normal URL parsing |
There was a problem hiding this comment.
These comments are not useful (and do not appear in the spec).
| // Everything else goes through normal URL parsing | ||
| if (!stateOverride && !this.url.scheme && /^[a-zA-Z]:\\/u.test(this.input)) { | ||
| const converted = this.input.replace(/\\/gu, "/"); | ||
| this.input = `file:///${converted}`; |
There was a problem hiding this comment.
These changes do not match the spec text at https://github.com/whatwg/url/pull/874/files#diff-29243b3b9b716b55c6a61970b0c4864f464b139d397fb961a05bb6e1e2b97cabR2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Windows file path handling as part of the WHATWG URL
spec change (whatwg/url#874).
Changes
percent-encoded Unicode
Implementation
When a Windows file path is detected at the start of URL parsing: