fix: handle invalid start and end byte positions in range parsing#57
Merged
blakeembrey merged 1 commit intojshttp:masterfrom Jan 21, 2026
Merged
fix: handle invalid start and end byte positions in range parsing#57blakeembrey merged 1 commit intojshttp:masterfrom
blakeembrey merged 1 commit intojshttp:masterfrom
Conversation
blakeembrey
approved these changes
Jan 21, 2026
Member
blakeembrey
left a comment
blakeembrey
left a comment
There was a problem hiding this comment.
LGTM.
I might do a follow up PR to be more complete, currently due to parseInt you can still get by with things like 100x- or 100.5, which should probably also be invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small bug that’s worth fixing closes #24